Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum requirement for sqlalchemy to 1.4.24 #1353

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

LazyMan145
Copy link
Contributor

Some of the recent sqlalchemy 2 changes used features that were added in 1.4.24 sqlalchemy (session.scalar) [1]. This change fixes the issue with gnocchi-upgrade built with wrong constraints.

  1. https://docs.sqlalchemy.org/en/20/changelog/changelog_14.html#change-e619b9bd2796d7e0b948631fac5b01e9

(cherry picked from commit 680ac01)

@LazyMan145
Copy link
Contributor Author

Fixes #1349

@tobias-urdin
Copy link
Contributor

The jobs will be green when this is rebased.

@tobias-urdin
Copy link
Contributor

@Mergifyio rebase

Some of the recent sqlalchemy 2 changes used features that were
added in 1.4.24 sqlalchemy (session.scalar) [1]. This change fixes the
issue with gnocchi-upgrade built with wrong constraints.

1. https://docs.sqlalchemy.org/en/20/changelog/changelog_14.html#change-e619b9bd2796d7e0b948631fac5b01e9

(cherry picked from commit 3e5aaf4)
Copy link
Contributor

mergify bot commented Feb 29, 2024

rebase

✅ Branch has been successfully rebased

@tobias-urdin tobias-urdin merged commit b37b943 into gnocchixyz:stable/4.6 Mar 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants