Redis: Fix sentinel fallbacks with IPv6 address #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes how the logic parses host and port from sentinel fallbacks when the host is IPv6 address. We should not use bare split by ':' because ':' is used within address representations like [::1]:6379.
kajinamit
force-pushed
the
sentinel-ipv6
branch
from
6742d84 to
e62a42c
Compare
tobias-urdin
approved these changes
Feb 29, 2024
|
@Mergifyio backport stable/4.6 |
✅ Backports have been created
|
tobias-urdin
added a commit
that referenced
this pull request
Aug 20, 2024
Redis: Fix sentinel fallbacks with IPv6 address (backport #1374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes how the logic parses host and port from sentinel fallbacks when the host is IPv6 address. We should not use bare split by ':' because ':' is used within address representations like [::1]:6379.