Remove the start/end filtering from aggregates resource query #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of the start/end filtering in resources listage in the aggregates api was generating an undesired behavior that was not showing measures of resources when the measures timestamp were from before the resources start time, which were displayed before this filter was introduced. This patch restores the old behavior.
chungg
approved these changes
Aug 19, 2024
tobias-urdin
requested changes
Aug 19, 2024
There was a problem hiding this comment.
am i understanding it correctly that this brings back looping through the entire dataset like was done before? so we keep the same behaviour that metrics with timestamp before resource start date is shown in the result?
but we still keep parts of the previous commit because it improves resource history by filtering in query instead of in code?
tobias-urdin
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the start/end filtering in resources listage in the aggregates api was generating an undesired behavior that was not showing measures of resources when the measures timestamp were from before the resources start time, which were displayed before this filter was introduced. This patch restores the old behavior.
To achieve the current filtering behavior, now the users must explicitly apply these start/end filtering in the "search"
parameter in the aggregates query.