Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function call issue for parsing sentinel_fallback #1405

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Function call issue for parsing sentinel_fallback #1405

merged 1 commit into from
Sep 2, 2024

Conversation

itsfarbod
Copy link
Contributor

Hi,
The _parse_sentinel was a class function and when it get called by

sentinel_hosts = [
            _parse_sentinel(fallback)
            for fallback in kwargs.pop('sentinel_fallback', [])
        ]

It made errors because it doesn't pass cls to it and it can't receive the sentinel.
So I made it static and tested it and its OK now.

@tobias-urdin tobias-urdin merged commit abd2359 into gnocchixyz:master Sep 2, 2024
23 checks passed
@tobias-urdin
Copy link
Contributor

@Mergifyio backport stable/4.6

Copy link
Contributor

mergify bot commented Sep 2, 2024

backport stable/4.6

✅ Backports have been created

tobias-urdin added a commit that referenced this pull request Sep 2, 2024
Function call issue for parsing sentinel_fallback (backport #1405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants