Run test_local_deployment in local chain #523

kongzii · 2024-10-22T10:59:45Z

No description provided.

coderabbitai · 2024-10-22T10:59:51Z

Walkthrough

The changes in this pull request primarily affect the DeployableTraderAgent class in the prediction_market_agent_tooling/deploy/agent.py file, specifically the process_market method. The logic for executing trades has been restructured to include a check for the self.place_bet attribute within the trade execution loop, enhancing logging clarity by including market URLs. Additionally, a test for local deployment has been removed from one test file, while a new test for the same functionality has been added to another file, utilizing mocking for improved control during testing.

Changes

File	Change Summary
`prediction_market_agent_tooling/deploy/agent.py`	Modified `process_market` method to check `self.place_bet` inside the loop, enhancing logging for skipped trades. `placed_trades` list now only populated if trades are executed.
`tests_integration/deploy/test_deploy.py`	Removed test function `test_local_deployment`.
`tests_integration_with_local_chain/deploy/test_deploy.py`	Added new test function `test_local_deployment` utilizing mocking for `get_web3`.

Possibly related PRs

Updating langfuse integration #345: Modifies the process_market method in the DeployableTraderAgent class, directly related to the changes made in the main PR.
Info logs about market process progress #407: Enhances logging in the process_market method, aligning with the main PR's improvements.
Default to tiny bet in DeployableTraderAgent #465: Updates the get_betting_strategy method in the DeployableTraderAgent, relevant to the overall betting strategy logic.
Refactor omen-specific logic out of DeployableTraderAgent + fix minimum required balance to operate #493: Introduces changes to the process_market and check_min_required_balance_to_trade methods, relevant to the trade execution logic modifications.

Suggested reviewers

evangriffiths

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between fd4ce6c and ede3b91.

📒 Files selected for processing (3)

prediction_market_agent_tooling/deploy/agent.py (2 hunks)
tests_integration/deploy/test_deploy.py (0 hunks)
tests_integration_with_local_chain/deploy/test_deploy.py (1 hunks)

💤 Files with no reviewable changes (1)

tests_integration/deploy/test_deploy.py

🧰 Additional context used

🔇 Additional comments (3)

tests_integration_with_local_chain/deploy/test_deploy.py (2)

1-7: LGTM: Imports are well-organized and relevant.

The imports are logically grouped and separated by empty lines, following good Python practices. All imported modules are relevant to the test function.

10-16: Consider adding assertions to verify deployment success.

The test function successfully sets up the environment for local deployment, but it lacks assertions to verify the deployment's outcome or behavior. This may result in a test that passes even if the deployment fails silently.

Consider adding assertions to check:

If the agent was deployed successfully.

If the agent's state after deployment is as expected.

If any expected side effects occurred (e.g., specific logs were generated).

Would you like assistance in drafting these assertions or in identifying specific aspects of the deployment to verify?

prediction_market_agent_tooling/deploy/agent.py (1)

Line range hint 461-478: Improved logging and trade execution flow

The changes enhance the logging granularity and trade execution flow:

Moving the self.place_bet check inside the loop allows for logging of skipped trades.

Adding the market URL to the log message improves traceability.

The logic for populating placed_trades remains correct, ensuring only executed trades are recorded.

These modifications provide better visibility into the agent's decision-making process regarding trade placements without altering the core functionality.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

kongzii · 2024-10-22T11:00:58Z

tests_integration_with_local_chain/deploy/test_deploy.py

+
+def test_local_deployment(local_web3: Web3) -> None:
+    with patch.object(ContractBaseClass, "get_web3", return_value=local_web3):
+        DeployableCoinFlipAgent(enable_langfuse=False).deploy_local(


Now we can place bets, but I disabled the language; no need to spam it with this test.

kongzii · 2024-10-22T11:01:40Z

prediction_market_agent_tooling/deploy/agent.py

-            for trade in trades:
-                logger.info(f"Executing trade {trade} on market {market.id}")
+        for trade in trades:
+            logger.info(f"Executing trade {trade} on market {market.id} ({market.url})")


Moved the if self.place_bet check just to see what bets would be placed during testing.

evangriffiths

🙌

Run test_local_deployment in local chain

ede3b91

kongzii mentioned this pull request Oct 22, 2024

Make test test_local_deployment use chain fork instead of the real chain #353

Closed

kongzii commented Oct 22, 2024

View reviewed changes

evangriffiths approved these changes Oct 22, 2024

View reviewed changes

kongzii merged commit 5c93252 into main Oct 23, 2024
14 checks passed

kongzii deleted the peter/local-test branch October 23, 2024 07:08

This was referenced Oct 23, 2024

Split DeployableTraderAgent into DeployablePredictionAgent #525

Merged

Allow for different configurations of DeployablePredictionAgent.same_market_trade_interval #531

Merged

Added limit as a configurable variable to DeployablePredictionAgent #532

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run test_local_deployment in local chain #523

Run test_local_deployment in local chain #523

kongzii commented Oct 22, 2024

coderabbitai bot commented Oct 22, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

kongzii Oct 22, 2024

kongzii Oct 22, 2024

evangriffiths left a comment

Run test_local_deployment in local chain #523

Run test_local_deployment in local chain #523

Conversation

kongzii commented Oct 22, 2024

coderabbitai bot commented Oct 22, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

kongzii Oct 22, 2024

Choose a reason for hiding this comment

kongzii Oct 22, 2024

Choose a reason for hiding this comment

evangriffiths left a comment

Choose a reason for hiding this comment

coderabbitai bot commented Oct 22, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)