-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize with roles #22
base: main
Are you sure you want to change the base?
Conversation
…iac-modifier-roles * NOTE: tests broken
/// Role not allowed to call this function on target address | ||
error FunctionNotAllowed(); | ||
|
||
bytes4 internal constant FALLBACK_FUNCTION_SIG = 0x00000000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to disambiguate between the fallback function and a function with the signature 0x00000000
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought they were the same? I never thought about this, but this is true, technically there could be some signature out there that yields 0x00000000
I chatted about this Adam, and he agreed that in roles we would handle the fallback function case via this function signature, the bytes4(0)
This is WIP merge request. Some remarks:
Clearance
andExecutionOptions
** This triggered a rewrite of the main check function. The style used by this function is very similar to style used by the checkTransaction function in roles
** allowTarget
** revokeTarget
** scopeTarget
setExecutionOptions
function as standalone. I think it could become ambiguous otherwiseOpen question: