Merge pull request #103 from gnosisguild/fix-spark-connect

Fix spark connect
gnosisguild · May 2, 2024 · e681314 · e681314
2 parents a90891f + 0463cec
commit e681314
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 4 deletions.
diff --git a/extension/src/bridge/SafeAppBridge.ts b/extension/src/bridge/SafeAppBridge.ts
@@ -46,6 +46,7 @@ export const SAFE_APP_WHITELIST = [
   'https://app.balancer.fi',
   'https://stake.lido.fi',
   'https://curve.fi',
+  'https://app.spark.fi',
 ]
 
 export default class SafeAppBridge {

diff --git a/extension/src/browser/Drawer/RolePermissionCheck.tsx b/extension/src/browser/Drawer/RolePermissionCheck.tsx
@@ -1,11 +1,15 @@
 import React, { useMemo } from 'react'
 import { useEffect, useState } from 'react'
 import { RiGroupLine } from 'react-icons/ri'
-import { encodeSingle, TransactionInput } from 'react-multisend'
+import {
+  encodeSingle,
+  MetaTransaction,
+  TransactionInput,
+} from 'react-multisend'
 
 import { Flex, Tag } from '../../components'
 import { useApplicableTranslation } from '../../transactionTranslations'
-import { Connection, JsonRpcError, TransactionData } from '../../types'
+import { Connection, JsonRpcError } from '../../types'
 import { decodeRolesV1Error } from '../../utils'
 import {
   decodeGenericError,
@@ -23,7 +27,7 @@ import { useTenderlyProvider } from '../../providers'
 import { TenderlyProvider } from '../../providers/ProvideTenderly'
 
 const simulateRolesTransaction = async (
-  encodedTransaction: TransactionData,
+  encodedTransaction: MetaTransaction,
   connection: Connection,
   tenderlyProvider: TenderlyProvider
 ) => {

diff --git a/extension/src/injection.ts b/extension/src/injection.ts
@@ -63,6 +63,23 @@ window.addEventListener('eip6963:requestProvider', () => {
 
 announceEip6963Provider(injectedProvider)
 
+// override EIP-6963 provider announcement for MetaMask
+window.addEventListener('eip6963:announceProvider', (event) => {
+  const ev = event as CustomEvent
+  if (ev.detail.info.rdns === 'io.metamask' && !ev.detail.metamaskOverride) {
+    window.dispatchEvent(
+      new CustomEvent('eip6963:announceProvider', {
+        detail: Object.freeze({
+          info: ev.detail.info,
+          provider: injectedProvider,
+          metamaskOverride: true,
+        }),
+      })
+    )
+    event.stopImmediatePropagation()
+  }
+})
+
 window.dispatchEvent(new Event('ethereum#initialized'))
 
 export {}
diff --git a/extension/src/transactionTranslations/cowswapSetPreSignature.ts b/extension/src/transactionTranslations/cowswapSetPreSignature.ts
@@ -68,7 +68,7 @@ export default {
       (response) => response.json()
     )
 
-    const validDuration = 60 * 30 // 30 minutes
+    const validDuration = order.validTo - Math.floor(Date.now() / 1000)
     const feeAmountBP = Math.ceil(
       (parseInt(order.feeAmount) / parseInt(order.sellAmount)) * 10000
     )