fix: improve form (#120)

* Make checkboxes false by default * Add privacy policy
gnoverse · Sep 24, 2023 · 1ac88b3 · 1ac88b3
1 parent bca4d58
commit 1ac88b3
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 10 deletions.
diff --git a/signup/functions/subscribe.ts b/signup/functions/subscribe.ts
@@ -7,7 +7,6 @@ import { CONFIG } from './config';
 import { SubscribeRequest } from './types';
 import subscribeUserSchema from './schemas/users.schema';
 import { RedisClient } from './services/redis';
-import RequestHelper from './helpers/requests.helper';
 import getRandomToken from './helpers/token.helper';
 
 const ajv = new Ajv();
@@ -34,7 +33,7 @@ export async function handler(event: HandlerEvent): Handler {
     if (!isValid) {
       return {
         statusCode: 400,
-        body: JSON.stringify({ errors: ajv.errors })
+        body: JSON.stringify({ errors: 'Bad request' })
       };
     }
 
@@ -63,7 +62,6 @@ export async function handler(event: HandlerEvent): Handler {
         MMERGE9: subscribeRequest.receiveNews ? 'Yes' : 'No',
         MMERGE10: subscribeRequest.termsAndConditions ? 'Yes' : 'No'
       }
-      // TODO add tags
     });
 
     await redisClient.storeUserToken(subscribeRequest.email, token);
@@ -81,6 +79,7 @@ export async function handler(event: HandlerEvent): Handler {
     if (journeyResponse != null) {
       throw new Error(journeyResponse);
     }
+
     // Success return
     return {
       statusCode: 200,
@@ -91,9 +90,10 @@ export async function handler(event: HandlerEvent): Handler {
       req: event.body,
       message: err
     });
+
     return {
       statusCode: 500,
-      body: JSON.stringify({ errors: { message: 'Unabled to subsribe user' } })
+      body: JSON.stringify({ errors: { message: 'Unable to subscribe user' } })
     };
   }
 }
diff --git a/signup/functions/types.ts b/signup/functions/types.ts
@@ -0,0 +1,11 @@
+export interface SubscribeRequest {
+  firstName: string;
+  lastName: string;
+  email: string;
+  githubHandle: string;
+  socialHandle: string;
+  interests: string;
+  receiveNews: boolean;
+  participate: boolean;
+  termsAndConditions: boolean;
+}
diff --git a/signup/src/components/pages/Home/Home.tsx b/signup/src/components/pages/Home/Home.tsx
@@ -36,8 +36,8 @@ const Home: FC<IHomeProps> = () => {
       githubHandle: '',
       socialHandle: '',
       interests: 'General Gno.land',
-      receiveNews: true,
-      participate: true,
+      receiveNews: false,
+      participate: false,
       termsAndConditions: false
     },
     enableReinitialize: true,
@@ -283,13 +283,23 @@ const Home: FC<IHomeProps> = () => {
               >
                 Please confirm you accept the{' '}
                 <a
-                  href={'https://hackmd.io'}
+                  href={'https://gnochess.com/docs/gnochess-terms-and-conditions-9-21-23.pdf'}
                   target={'_blank'}
                   style={{
                     textDecoration: 'underline'
                   }}
                 >
-                  Terms and Conditions{' '}
+                  Terms and Conditions
+                </a>
+                {' '}and the{' '}
+                <a
+                  href={'https://gnochess.com/docs/gnochess-privacy-policy-9-21-23.pdf'}
+                  target={'_blank'}
+                  style={{
+                    textDecoration: 'underline'
+                  }}
+                >
+                  Privacy Policy
                 </a>
               </Checkbox>
               <FormHelperText>
@@ -303,11 +313,11 @@ const Home: FC<IHomeProps> = () => {
           <Box>
             <Button
               rightIcon={<BsSend />}
-              variant="outline"
+              variant='outline'
               padding={6}
               isLoading={submitting}
               loadingText={'Submitting'}
-              spinner={<Spinner size={'md'} color="green" />}
+              spinner={<Spinner size={'md'} color='green' />}
               spinnerPlacement={'end'}
               type={'submit'}
             >