cmake: Apply cmake-format #615
Conversation
jdemel
force-pushed
the
add-clang-formatter
branch
from
701039a to
1337011
Compare
jdemel
force-pushed
the
add-clang-formatter
branch
from
1337011 to
11ab110
Compare
| if( | ||
| MINGW | ||
| OR CYGWIN | ||
| OR WIN32) |
There was a problem hiding this comment.
I re-added the corresponding file from gnuradio and the result is almost the same but without the new line after if(. I'd assume this is intended.
| set( | ||
| CMAKE_C_FLAGS | ||
| ${CMAKE_CXX_FLAGS} | ||
| CACHE STRING "" FORCE) #same flags for C sources |
There was a problem hiding this comment.
Not sure, but this looks pretty different than GR's formatting. You're closing an issue that says "format like GNU Radio" with this!
|
If you want to be close to the GNU Radio version, so go and copy the GNU Radio version, I'd say. |
I'm pretty sure, I did. I saw you @marcusmueller made some further adjustments to the GR CMake formatting. I should probably get an updated version of this. |
We want to use this to auto-format our cmake files. Signed-off-by: Johannes Demel <[email protected]>
Run: ``` cmake-format -c .cmake-format.py -i $(git ls-files | grep CMakeLists.txt) $(git ls-files cmake/ | grep .cmake) ``` This applies the cmake formatting as defined in all files. In order to install `cmake-format`, you might want to run `pip install cmakelang` Or use another package manager of your choice. Signed-off-by: Johannes Demel <[email protected]>
jdemel
force-pushed
the
add-clang-formatter
branch
from
11ab110 to
e165c92
Compare
|
I copied the |
cmake: Apply cmake-format
This commit adds
.cmake-format.py. It is mostly inspired by the GNU Radio version of it.Steps to reproduce these results:
pip3 install cmakelangcmake-format --dump-config python > .cmake-format.pycmake-format -c .cmake-format.py -i $(git ls-files | grep CMakeLists.txt) $(git ls-files | grep .cmake)Fixes #600
Fixes #423