Use absolute tolerance for stddev_and_mean #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clayton Smith <[email protected]>
|
The test failure is unrelated; it's due to #646. |
Alesha72003
pushed a commit
to Alesha72003/volk
that referenced
this pull request
May 15, 2024
Use absolute tolerance for stddev_and_mean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #648.
qa_volk_32f_stddev_and_mean_32f_x2frequently fails. The problem is that the mean value of uniformly distributed points ends up very close to zero, where the relative error can be huge even when the absolute error is small. We care about absolute error here, so I've switched the test to check the absolute error. After doing so, the test happily runs in a loop without failure: