convert 32f->32i: fix compiler warnings about loss of int precision #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compilers warn that converting INT_MAX to float leads to INT_MAX+1 as float value. That's absolutely not surprising: bits(single precision float mantissa) < bits(int), so an int of value 2^N - 1 must inherently be non-representable for N close to bits(int), and MAX_INT = 2³²-1. So, the upround that I'm doing here explicitly is always done, on every machine I could think of, and so what this compiler warning silencing does is always done, anyways. Finally makes VOLK a zero-warning compile on my clang16 x68_64 avx2 machine. Signed-off-by: Marcus Müller <[email protected]>
marcusmueller
force-pushed
the
fix_compile_warnings
branch
from
ea6fcca to
4fe47b3
Compare
argilo
approved these changes
Oct 20, 2023
Alesha72003
pushed a commit
to Alesha72003/volk
that referenced
this pull request
May 15, 2024
convert 32f->32i: fix compiler warnings about loss of int precision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feels like someone else probably has an open PR about it already, but I can't find it.
Compilers warn that converting INT_MAX to float leads to INT_MAX+1 as float value.
That's absolutely not surprising: bits(single precision float mantissa) < bits(int), so an int of value 2^N - 1 must inherently be non-representable for N close to bits(int), and MAX_INT = 2³²-1.
So, the upround that I'm doing here explicitly is always done, on every machine I could think of, and so what this compiler warning silencing does is always done, anyways.
Finally makes VOLK a zero-warning compile on my clang16 x68_64 avx2 machine.