Fix register size warnings in reverse kernel #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clayton Smith <[email protected]>
|
The test failure is unrelated; it's due to #669. |
Alesha72003
pushed a commit
to Alesha72003/volk
that referenced
this pull request
May 15, 2024
Fix register size warnings in reverse kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building VOLK on 64-bit ARM, many compiler warnings are printed because the register size of the
rbitinstruction is incorrect. To fix that, I've added an aarch64 version of theDO_RBITmacro which includes thewtemplate modifier to select 32-bit registers.Also, it appears the
armversion of the reverse kernel was inaccessible (on both 32-bit and 64-bit ARM) becausevolk_kernel_defs.pydoes not understand nested#ifdef LV_HAVE_*. I separated the#ifdefs and now thearmversion of the kernel runs on both 32-bit and 64-bit ARM.