Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for rounding error in float-to-int interleave #718

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

argilo
Copy link
Member

@argilo argilo commented Dec 9, 2023

When building in the ASAN configuration on i386, the volk_32f_x2_s32f_interleave_16ic and qa_volk_32fc_s32f_deinterleave_real_16i tests fail due to integer rounding error:

RUN_VOLK_TESTS: volk_32f_x2_s32f_interleave_16ic(131071,1)
a_sse2 completed in 0.194501 ms
a_sse completed in 2.05456 ms
generic completed in 2.39459 ms
offset 176115 in1: -65 in2: -64 tolerance was: 0
volk_32f_x2_s32f_interleave_16ic: fail on arch a_sse2
offset 176115 in1: -65 in2: -64 tolerance was: 0
volk_32f_x2_s32f_interleave_16ic: fail on arch a_sse
RUN_VOLK_TESTS: volk_32fc_s32f_deinterleave_real_16i(131071,1)
a_sse completed in 0.970632 ms
generic completed in 1.07902 ms
offset 45409 in1: 307 in2: 306 tolerance was: 0
offset 54423 in1: -263 in2: -262 tolerance was: 0
offset 108811 in1: 229 in2: 230 tolerance was: 0
volk_32fc_s32f_deinterleave_real_16i: fail on arch a_sse

To fix this, I've increased their tolerances to 1, after which the tests pass reliably.

@argilo argilo mentioned this pull request Dec 9, 2023
Copy link
Contributor

@jdemel jdemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdemel jdemel merged commit 0354f37 into gnuradio:main Dec 10, 2023
32 checks passed
Alesha72003 pushed a commit to Alesha72003/volk that referenced this pull request May 15, 2024
Allow for rounding error in float-to-int interleave
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants