Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Initial commit of updated IPv6" #313

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

rfm
Copy link
Contributor

@rfm rfm commented Aug 18, 2023

Reverts #307
Oops ...I was wrong to do that.

@rfm
Copy link
Contributor Author

rfm commented Aug 18, 2023

This change introduces a lot of compiler warnings, and I wonder if it actually does anything useful; the original code already has struct socket_any which is a union containing sockaddr_in6 (the IPV6 socket address) and is therefore both correctly aligned and correctly sized.

@gcasa
Copy link
Member

gcasa commented Aug 18, 2023

@RoyalStewart90 Can you address the questions @rfm has raised?

@rfm rfm merged commit 01c73a8 into master Aug 19, 2023
9 checks passed
@rfm
Copy link
Contributor Author

rfm commented Aug 19, 2023

I reverted that and added the bit that appears to be functional in Source/win32/NSStream.m
When we can't create IPV4 streams, try to create IPV6:

if (!ins)
{
#if defined(PF_INET6)
ins = AUTORELEASE([[GSInet6InputStream alloc]
initToAddr: address port: port]);
outs = AUTORELEASE([[GSInet6OutputStream alloc]
initToAddr: address port: port]);
#endif
}

@rfm rfm deleted the revert-307-Eggplant-Improved-IPv6-Support branch October 23, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants