Try to address issue of treating pointer function values as bitfield #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfm
reviewed
Aug 19, 2023
There was a problem hiding this comment.
This all looks very reasonable.
A couple of pedantic suggestions though:
The definition of IS_WEAK should really use || (logical or) rather than | (bitwise)
The memoryType() and personalityType() functions should really be of the form
return ((options & mask) == flag) ? YES : NO;
I don't think those change the way the code behaves, but it would make it clearer than we are working with booleans.
Also, I don't use any of this pointer function code myself ... so I wonder if we should be adding testcases to exercise the various possibilities (and make sure we don't break anything).
|
I addressed you point and yes, having a few tests for this functionality would surely help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not fix all the issues that were reported. At least it tries to sort out the bitfield access to the memory and personality options on pointer functions.