* Tests/gui/NSBezierPath/windingCountAtPoint.m

* Tests/gui/NSCell/basic.m * Tests/gui/NSEvent/delta.m * Tests/gui/NSPasteboard/lazy_copy.m * Tests/gui/NSSavePanel/setDelegate_reload.m * Tests/gui/NSSliderCell/minMax.m * Tests/gui/NSView/NSView_visibleRect.m Remove comipler warnings in test code. * Tests/gui/TextSystem/deallocation.m Move auto release pool inside of the test set to get the test working again.
gnustep · Dec 28, 2017 · d6a1c11 · d6a1c11
1 parent 441af14
commit d6a1c11
Show file tree

Hide file tree

Showing 8 changed files with 28 additions and 15 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,16 @@
+2017-12-28 Fred Kiefer <[email protected]>
+
+	* Tests/gui/NSBezierPath/windingCountAtPoint.m
+	* Tests/gui/NSCell/basic.m
+	* Tests/gui/NSEvent/delta.m
+	* Tests/gui/NSPasteboard/lazy_copy.m
+	* Tests/gui/NSSavePanel/setDelegate_reload.m
+	* Tests/gui/NSSliderCell/minMax.m
+	Remove comipler warnings in test code.
+	* Tests/gui/TextSystem/deallocation.m
+	Move auto release pool inside of the test set to get the test
+	working again.
+
 2017-12-28 Fred Kiefer <[email protected]>
 
 	* Printing/GSCUPS/GSCUPSPrinter.m,

diff --git a/Tests/gui/NSBezierPath/windingCountAtPoint.m b/Tests/gui/NSBezierPath/windingCountAtPoint.m
@@ -117,8 +117,6 @@ int main(int argc, char **argv)
 {
 	CREATE_AUTORELEASE_POOL(arp);
 	NSBezierPath *p=[[NSBezierPath alloc] init];
-	NSRect r;
-	float x;
 	int i;
 	const char *str;
 	int X=-1000;

diff --git a/Tests/gui/NSCell/basic.m b/Tests/gui/NSCell/basic.m
@@ -53,20 +53,21 @@ - (BOOL) isEqual: (id)anObject
     return YES;
   if (![anObject isKindOfClass: [NSCell class]])
     return NO;
-  if (![[anObject stringValue] isEqual: [self stringValue]])
+  if (![[(NSCell *)anObject stringValue] isEqual: [self stringValue]])
     return NO;
-  if (![[anObject title] isEqual: [self title]])
+  if (![[(NSCell *)anObject title] isEqual: [self title]])
     return NO;
-  if (!([anObject image] == [self image]) && ![[anObject image] isEqual: [self image]])
+  if (!([(NSCell *)anObject image] == [self image])
+      && ![[(NSCell *)anObject image] isEqual: [self image]])
     {
       NSLog(@"image differ %@ %@", [self image], [anObject image]);
       return NO;
     }
-  if ([anObject type] != [self type])
+  if ([(NSCell *)anObject type] != [self type])
     return NO;
-  if ([anObject tag] != [self tag])
+  if ([(NSCell *)anObject tag] != [self tag])
     return NO;
   return YES;
 }
 
-@end
+@end
diff --git a/Tests/gui/NSEvent/delta.m b/Tests/gui/NSEvent/delta.m
@@ -1,6 +1,7 @@
 #include "Testing.h"
 
 #include <Foundation/NSAutoreleasePool.h>
+#include <Foundation/NSDictionary.h>
 #include <Foundation/NSString.h>
 
 #include <AppKit/NSApplication.h>

diff --git a/Tests/gui/NSPasteboard/lazy_copy.m b/Tests/gui/NSPasteboard/lazy_copy.m
@@ -29,10 +29,9 @@ int main(int argc, char **argv)
 	CREATE_AUTORELEASE_POOL(arp);
 
 	NSPasteboard *pb=[NSPasteboard pasteboardWithName: @"lazy copy test"];
-	int i;
 	NSString *s;
 
-	i=[pb declareTypes: [NSArray arrayWithObject: NSStringPboardType]
+	[pb declareTypes: [NSArray arrayWithObject: NSStringPboardType]
 		owner: [Foo self]];
 	DESTROY(arp);
 

diff --git a/Tests/gui/NSSavePanel/setDelegate_reload.m b/Tests/gui/NSSavePanel/setDelegate_reload.m
@@ -9,6 +9,10 @@
 
 #include <AppKit/AppKit.h>
 
+@interface NSSavePanel (TestDelegate)
+- (NSMatrix *)lastColumnMatrix;
+@end
+
 @implementation NSSavePanel (TestDelegate)
 
 - (NSMatrix *)lastColumnMatrix
@@ -23,8 +27,6 @@ @interface Delegate : NSObject
 
 @implementation Delegate
 
-static BOOL pressed;
-static NSSavePanel *sp;
 
 + (BOOL) panel: (NSSavePanel *)p
 shouldShowFilename: (NSString *)fname

diff --git a/Tests/gui/NSSliderCell/minMax.m b/Tests/gui/NSSliderCell/minMax.m
@@ -11,7 +11,6 @@ int main()
 {
   CREATE_AUTORELEASE_POOL(arp);
   NSSliderCell *cell;
-  NSNumber *num;
 
   START_SET("NSSliderCell GNUstep minMax")
 

diff --git a/Tests/gui/TextSystem/deallocation.m b/Tests/gui/TextSystem/deallocation.m
@@ -23,9 +23,9 @@
   NSTextStorage *ts;
   NSTextContainer *tc;
   NSTextView *tv;
-  CREATE_AUTORELEASE_POOL(arp);
 
   START_SET("TextSystem GNUstep deallocation")
+  CREATE_AUTORELEASE_POOL(arp);
 
   NS_DURING
   {
@@ -81,8 +81,8 @@
   pass([tv layoutManager] == nil, "NSTextView -layoutManager returns nil");
   pass([tv textStorage] == nil, "NSTextView -textStorage returns nil");
 
+  DESTROY(arp);
   END_SET("TextSystem GNUstep deallocation")
 
-  DESTROY(arp);
   return 0;
 }