Implement missing functions #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecbaldwin
force-pushed
the
implement-missing
branch
from
dea9cf4
to
0bdb33d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess we had a few todos in IPv6. Implementing them here.
In IPv6, there are currently no NumAddresses implemented on Prefix, Range, Set, nor Set_. Also, WalkAddresses is not implemented on Set. This actually intentional but I might rethink it.
Instead of NumAddresses, IsEmpty is implemented on Set and Set_ in IPv6. However, Prefix and Range do not have it.