feat: add route.RequestContentType #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanhitt
force-pushed
the
RequestContent
branch
2 times, most recently
from
1169eee
to
15ebe2c
Compare
dylanhitt
commented
Aug 29, 2024
Provides the ability for the user to explicitly set what content types and request body can be. Maintains the defaullt of `application/json` and `application/xml`
dylanhitt
force-pushed
the
RequestContent
branch
from
15ebe2c
to
961c5ce
Compare
ccoVeille
reviewed
Aug 29, 2024
| @@ -19,6 +19,8 @@ func (rs PetsRessources) Routes(s *fuego.Server) { | |||
| fuego.Get(petsGroup, "/{id}", rs.getPets) | |||
| fuego.Get(petsGroup, "/by-name/{name...}", rs.getPetByName) | |||
| fuego.Put(petsGroup, "/{id}", rs.putPets) | |||
| fuego.Put(petsGroup, "/{id}/json", rs.putPets). | |||
| RequestContentType("application/json") | |||
There was a problem hiding this comment.
maybe
Suggested change
| RequestContentType("application/json") | |
| ExpectContentType("application/json") |
or
Suggested change
| RequestContentType("application/json") | |
| RequireContentType("application/json") |
or
Suggested change
| RequestContentType("application/json") | |
| AcceptContentType("application/json") |
What do you think?
There was a problem hiding this comment.
Not sure I'm following?
We're applying the Content-Type for the openapi RequestBody. The following follows the semantics that was used for other operations.
There was a problem hiding this comment.
I assumed the method was expecting the caller to send this.
I might have misunderstood the PR purpose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #159
Provides the ability for the user to explicitly
set what content types and request body can be.
Maintains the defaullt of
application/jsonandapplication/xml