feat: add tags to the Server (i.e Group) level #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanhitt
force-pushed
the
feat/group-tags
branch
from
ca6327a
to
b9666fd
Compare
dylanhitt
changed the title
EwenQuim
reviewed
Mar 21, 2024
| @@ -45,6 +46,8 @@ type Server struct { | |||
| // For example, it allows OPTIONS /foo even if it is not declared (only GET /foo is declared). | |||
| corsMiddleware func(http.Handler) http.Handler | |||
|
|
|||
| tags []string | |||
There was a problem hiding this comment.
Add a comment to explain that it is OpenAPI tags
dylanhitt
force-pushed
the
feat/group-tags
branch
2 times, most recently
from
8606586
to
61cf0f9
Compare
dylanhitt
force-pushed
the
feat/group-tags
branch
from
61cf0f9
to
3322250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62
I put the test where I thought they made sense the most. I added a test for
TestRegisterto specifically ensure routes have the last say. Let me know what you think. Happy to move things around, but I believe I have most things covered.Cheers