Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Implementation of required workflows Actions #31869

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WIP Implementation of required workflows Actions #31869

wants to merge 2 commits into from
+681 −15

Conversation

AvengerMoJo
Copy link

It is a large PR, would like to add this updated PR to replace #30067 and start creating test cases for it.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 19, 2024
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 19, 2024
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/js labels Aug 19, 2024
@AvengerMoJo AvengerMoJo mentioned this pull request Aug 23, 2024
Closed
@AvengerMoJo AvengerMoJo force-pushed the wip_require_action branch 2 times, most recently from c0d50fd to 3b8177f Compare August 23, 2024 09:54
@lunny
Copy link
Member

lunny commented Aug 26, 2024

It's too flexible to allow the workflows from any repositories. How about only allow workflows from a special repository like <org>/.workflows?

@AvengerMoJo
Copy link
Author

It's too flexible to allow the workflows from any repositories. How about only allow workflows from a special repository like <org>/.workflows?

Sure, @lunny thanks for reviewing, let me put that filter logic in. I was trying to implement the basic minimal feature and discuss the implementation details with the actions maintainer so any suggestion is welcome.
Meanwhile, should I keep this WIP branch or I create another branch in my home repo called require_action. https://github.com/AvengerMoJo/gitea/tree/require_action

@lunny
Copy link
Member

lunny commented Aug 26, 2024

It's too flexible to allow the workflows from any repositories. How about only allow workflows from a special repository like <org>/.workflows?

Sure, @lunny thanks for reviewing, let me put that filter logic in. I was trying to implement the basic minimal feature and discuss the implementation details with the actions maintainer so any suggestion is welcome. Meanwhile, should I keep this WIP branch or I create another branch in my home repo called require_action. https://github.com/AvengerMoJo/gitea/tree/require_action

Maybe keeping them in the same PR is better? So later reviewers can have context in the same place?

@yp05327
Copy link
Contributor

yp05327 commented Sep 17, 2024 •
edited
Loading

Typo in title? RequestActions? RequireActions?

@AvengerMoJo AvengerMoJo changed the title WIP Implementation of RequestActions WIP Implementation of required workflows Actions Sep 17, 2024
@AvengerMoJo
Copy link
Author

@lunny adding a filter to make sure only .workflow repo could add as Global Required Workflow actions

@AvengerMoJo
Copy link
Author

Typo in title? RequestActions? RequireActions?

@yp05327 fixed, along with the filter for .workflow repo only to enable global required workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code modifies/js modifies/templates This PR modifies the template files modifies/translation size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AvengerMoJo @lunny @yp05327 @GiteaBot