Feature: Support workflow event dispatch via API #32059
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XL
github-actions
bot
added
modifies/api
Signed-off-by: Bence Santha <[email protected]>
Signed-off-by: Bence Santha <[email protected]>
Signed-off-by: Bence Santha <[email protected]>
Signed-off-by: Bence Santha <[email protected]>
pull-request-size
bot
added
size/XXL
Signed-off-by: Bence Santha <[email protected]>
Signed-off-by: Bence Santha <[email protected]>
pull-request-size
bot
added
size/XL
Signed-off-by: Bence Santha <[email protected]>
pull-request-size
bot
added
size/XXL
bencurio
changed the title
lunny
reviewed
Oct 3, 2024
Signed-off-by: Bence Santha <[email protected]>
lunny
reviewed
Oct 6, 2024
lunny
reviewed
Oct 11, 2024
services/actions/workflow.go
Outdated
| return | ||
| } | ||
| workflows, err := jobparser.Parse(content) | ||
| if err != nil || len(workflows) == 0 { |
There was a problem hiding this comment.
I fixed it by adding a check for both the error and the empty workflows case. Now, it handles the scenario where len(workflows) == 0 after confirming that err == nil, preventing a potential panic.
Signed-off-by: Bence Santha <[email protected]>
pull-request-size
bot
added
size/XL
lunny
reviewed
Oct 21, 2024
| m.Put("/{workflow_id}/disable", reqToken(), reqChecker, actw.DisableWorkflow) | ||
| m.Post("/{workflow_id}/dispatches", reqToken(), reqChecker, bind(api.CreateActionWorkflowDispatch{}), actw.DispatchWorkflow) | ||
| m.Put("/{workflow_id}/enable", reqToken(), reqChecker, actw.EnableWorkflow) | ||
| }, context.ReferencesGitRepo(), reqRepoWriter(unit.TypeActions)) |
There was a problem hiding this comment.
GET methods just need reqRepoReader(unit.TypeActions), POST and PUT needs reqRepoWriter(unit.TypeActions).
lunny
reviewed
Oct 21, 2024
| @@ -1107,6 +1123,11 @@ func Routes() *web.Router { | |||
| reqOwner(), | |||
| repo.NewAction(), | |||
| ) | |||
| addActionsWorkflowRoutes( | |||
| m, | |||
| reqRepoWriter(unit.TypeActions), | |||
There was a problem hiding this comment.
The second parameter seems unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #31765