uploader: handle X-Clickhouse-Exception-Code header #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we noticed that in case of an error ClickHouse sometimes can return a status code 200 with an actual error in
X-Clickhouse-Exception-Codeheader. This PR adds failing upload when this header is present in the response.We sometimes observed that happening after a timeout error on ClickHouse end. In the response there was a status code 200 and a 209 code in
X-ClickHouse-Exception-Code('socket timeout'). It caused a sporadic metric loss as ClickHouse didn't read the whole body and carbon-clickhouse considered the upload to be successful.I've also found a similar issue created for ClickHouse tests - ClickHouse/ClickHouse#44885.