chore: update golang-jwt/jwt and other modules #1261
Conversation
| // StandardClaimsFactory is a ClaimsFactory that returns | ||
| // an empty jwt.StandardClaims. | ||
| func StandardClaimsFactory() jwt.Claims { | ||
| return &jwt.StandardClaims{} | ||
| // RegisteredClaimsFactory is a ClaimsFactory that returns | ||
| // an empty jwt.RegisteredClaims. | ||
| func RegisteredClaimsFactory() jwt.Claims { | ||
| return &jwt.RegisteredClaims{} |
There was a problem hiding this comment.
In case naming consistency is not so critical, we can consider to keep StandardClaimsFactory so to avoid a breaking change in go kit.
From my understanding jwt.RegisteredClaims{} is mostly backwards compatible with jwt.StandardClaims{}.
Any feedback is appreciated
There was a problem hiding this comment.
Changing public API identifiers like this should probably be avoided if at all possible.
|
A major version bump signals backwards-incompatible changes, essentially an entirely different module than the previous major version. If you want to use jwt/v5 then I'd like to see it either as a new Go kit "jwt2" package, or a pretty comprehensive test suite to ensure that "mostly backwards compatible" actually means "fully backwards compatible" in terms of the API that Go kit offers to its consumers. |
This PR updates all go modules to the latest version.
The main changes are related to golang-jwt/jwt v5, for which I followed the migration guide.
The only breaking change I'm introducing in go kit is the rename of
StandardClaimsFactory()intoRegisteredClaimsFactory()in order to keep consistency with the underlying naming.