Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: don't use zero value of mysql.Result #969

Merged
merged 3 commits into from
Jan 14, 2025
Merged

*: don't use zero value of mysql.Result #969

merged 3 commits into from
Jan 14, 2025

Conversation

lance6716
Copy link
Collaborator 

// Result should be created by NewResultWithoutRows or NewResult. The zero value
// of Result is invalid.

closes #964

@lance6716 lance6716 requested a review from dveeden January 13, 2025 07:54
@lance6716
try to fix CI
f47c635 
Signed-off-by: lance6716 <[email protected]>
@lance6716
fix CI
573b1ed 
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Collaborator Author

@dveeden I have fixed CI, PTAL

@lance6716 lance6716 merged commit d02e79a into go-mysql-org:master Jan 14, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dveeden dveeden dveeden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#BUG: sql.Execute get rows count will panic nil error
2 participants
@lance6716 @dveeden