Resolving "Validating unexported fields #417" #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgerasimchuk
approved these changes
Feb 23, 2024
deankarn
requested changes
Feb 23, 2024
There was a problem hiding this comment.
Thanks for the PR!
I still have to review carefully, new laptop still in the mail so be a bit, but due to the use of unsafe I will request that this needs to become an opt-in option when initializing validator and documentation can indicate that and that opting in accepts that risk.
|
@deankarn thanks for your proposal, it looks valid. Changes added. |
|
@deankarn if I can speed up the review process, let me know. |
deankarn
approved these changes
Mar 2, 2024
d1slike
pushed a commit
to txix-open/validator
that referenced
this pull request
Apr 1, 2024
…ound#1234) go-playground#417 @go-playground/validator-maintainers --------- Co-authored-by: nikolay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add supporting for validation private fields #417
@go-playground/validator-maintainers