Use sync.OnceValue for lazy regexp initialization #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kke
force-pushed
the
sync-oncevalue-regex
branch
from
2c1e665
to
61e16c9
Compare
kke
force-pushed
the
sync-oncevalue-regex
branch
from
61e16c9
to
45664ca
Compare
Using sync.OnceValue instead of the local implementation brings some benefits in allocations, panic handling and mutex use / concurrent access after initialization. Signed-off-by: Kimmo Lehto <[email protected]>
sync.OnceValue was introduced in go1.21. Currently validator's go.mod states minimum go version to be go1.18. This commit moves the lazy regex initialization into its own file lazy.go and provides backwards compatibility using buildtags and the file lazy_compat.go which contains a backported (non-generic) version of sync.OnceValue. Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
kke
force-pushed
the
sync-oncevalue-regex
branch
from
86e99ce
to
dac5fe6
Compare
The coverage check does not seem to calculate correctly when files with build tags are involved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Replaces the local lazy initialization implementation with the stdlib
sync.OnceValue.Using sync.OnceValue instead of the local implementation brings some benefits in allocations, panic handling and mutex usage after initialization.
sync.OnceValuewas introduced in go1.21 so backwards compatibility is provided vialazy_compat.goand build tags.Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers