Opentype font writer #102
Merged
Opentype font writer #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitkugler
requested review from
whereswaldon and
andydotxyz
as code owners
andydotxyz
reviewed
Oct 14, 2023
opentype/loader/writer.go
Outdated
| // Write creates a single font file from the given [tables] slice, | ||
| // which must be sorted by Tag | ||
| func Write(tables []Table) []byte { | ||
| buffer := writeTTF(tables) |
There was a problem hiding this comment.
This function has a single purpose - to call writeTTF, which is strange - if it is generic we don't need the extra function, but if it is because this writer is for TTF perhaps the generic name isn't right?
There was a problem hiding this comment.
Fair point. In the future, we may want to support other formats, like web font (WOFF). In such case, the Write function would become Write(tables []Table, woff bool) []byte, and internally call writeTTF or writeWOFF.
But, for now, it seems indeed cleaner to drop the internal function and rename Write to, say, WriteTTF.
andydotxyz
approved these changes
Oct 16, 2023
whereswaldon
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to write an Opentype font file from a list of tables.
This is a simple implementation, since neither font collections nor compressed format (WOFF) are supported.
This paves the way for features such as subsetter or variable font instantiater.
Conceptually, the
Writefunction performs the reverse operation ofNewLoader, so that I think it should belong to this package.Note that the GUI toolkits are probably NOT interested by such features, but since the Go linker is able to remove dead code, it should come with no cost for end users anyway.