opentype, fontscan: remove go1.16 build constraints #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now this project uses Go 1.17 and newer, an old code for Go 1.15 and older should not be needed.
hajimehoshi
requested review from
whereswaldon,
benoitkugler and
andydotxyz
as code owners
|
I assumed this project uses Go 1.17 from go.mod, but perhaps do we need to test this with Go 1.14? |
|
Thank you for this contribution.
It was indeed the case, but now that Fyne has bumped its minimum version, I think it should be OK. |
andydotxyz
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now this project uses Go 1.17 and newer, an old code for Go 1.15 and older should not be needed.