Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shaping] fix handling of Inherited script in Segmenter.Split #128

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

benoitkugler
Copy link
Contributor

In Segmenter.Split, Inherited script must be handled like Common, to avoid creating more runs than required (which in turns does not allow harfbuzz to properly shape the whole text).
Fixes #127

Copy link
Member

@whereswaldon whereswaldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@whereswaldon whereswaldon merged commit 4b4ad9c into main Dec 14, 2023
20 checks passed
@whereswaldon whereswaldon deleted the issue127 branch December 14, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using Segmenter.Split causes a slightly different rendering result
2 participants