Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fontscan] expose system fonts #149

Merged
merged 2 commits into from
Mar 29, 2024
Merged

[fontscan] expose system fonts #149

merged 2 commits into from
Mar 29, 2024

Conversation

benoitkugler
Copy link
Contributor

This this a try at exposing the system fonts directly, without using the fontmap (for #141).

Let me know what you think.

cc @dominikh

@dominikh
Copy link
Contributor

This largely matches my local changes, LGTM

andydotxyz
andydotxyz approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good to me thanks

whereswaldon
whereswaldon approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@whereswaldon whereswaldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@benoitkugler benoitkugler merged commit ac44b0c into main Mar 29, 2024
20 checks passed
@benoitkugler benoitkugler deleted the fontscan-export-footprints branch March 29, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whereswaldon whereswaldon whereswaldon approved these changes

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benoitkugler @dominikh @andydotxyz @whereswaldon