Better case for Script #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe your heuristic was that if we don't know how to map the script to an OpenType tag, there's a small chance that the lowercase BCP 47 script tag is a valid OpenType tag? |
|
This is a good change, as Ebitengine cared about go-text's behavior (https://github.com/hajimehoshi/ebiten/blob/caecd81f4e9c2f8b3c7224956fc65538220b18aa/text/v2/gotext.go#L269-L272), and ISO 15924 says this is case-insensitive. |
andydotxyz
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @dominikh noticed, we currently use an odd convention for the binary representation of
Script. I'm not sure what my heuristic was, but it seems simply better to adopt the general title-case convention (Arab, notarab).The changes has few impact on the code, since we use constants anyway. However, the cache version number of fontscan has to be bumped since the current cache stores the scripts with the lowercase convention.
Closes #152