[font] Names decoding #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitkugler
requested review from
whereswaldon and
andydotxyz
as code owners
|
@benoitkugler |
|
Since this is a straightforward bugfix, it only needs one approval. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Windows fonts use UTF-16 encoding for their family names : we were missing some of them when decoding the 'name' table.
This a fix for #172 (and should also fix #171).
I've also updated the fontscan cache version, to ensure the existing footprints will be properly updated.
@akiyosi Could you confirm this fix resolves your initial issue ? Thank you !