Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(yaml): allow for users to set version legacy for buildkite #1230

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

ecrupper
Copy link
Contributor

Continuation of piecemealing #1220 together with smaller PRs. This PR introduces internal.ParseYAML which will attempt to parse the pipeline or template using go-yaml v3 unless version: legacy is declared at the top level of the file.

@ecrupper ecrupper requested a review from a team as a code owner December 23, 2024 18:05
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 56.64%. Comparing base (605647a) to head (148bdf4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/yaml.go 75.67% 6 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1230      +/-   ##
==========================================
+ Coverage   56.63%   56.64%   +0.01%     
==========================================
  Files         622      623       +1     
  Lines       35252    35280      +28     
==========================================
+ Hits        19964    19986      +22     
- Misses      14616    14620       +4     
- Partials      672      674       +2     
Files with missing lines Coverage Δ
compiler/native/parse.go 85.00% <100.00%> (-0.37%) ⬇️
compiler/template/native/render.go 86.56% <100.00%> (-0.39%) ⬇️
compiler/template/starlark/render.go 44.51% <100.00%> (-1.40%) ⬇️
internal/yaml.go 75.67% <75.67%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 72319ae into main Dec 26, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the fix/parse-yaml-by-version branch December 26, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants