feat(protocol): allow absent relying party id #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the use of a blank Relying Party ID which is permitted in the spec.
This adds tests and validates another element of te requirements.
mitar
reviewed
Dec 2, 2023
| var uri *url.URL | ||
|
|
||
| if len(config.RPID) != 0 { | ||
| if uri, err = url.Parse(config.RPID); err != nil { |
There was a problem hiding this comment.
I am not sure if parsing RPID makes sense? This should be generally be a domain name? So parsing as URL has little sense. I see that it was done like this before.
Spec here mentions:
Though, the RP ID syntaxes MUST conform to either valid domain strings or URIs [RFC3986] [URL].
But the later, URIs is only allowed for "Other specifications mimicking the WebAuthn API to enable WebAuthn public key credentials on non-Web platforms".
So I am not sure, but there is no requirement that it should not be absolute?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the use of a blank Relying Party ID which is permitted in the spec. This is a feature which is supported by level 1 and level 2 of the spec.
Closes #165