Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: backup flag validation #240

Merged
merged 4 commits into from
May 28, 2024
Merged

feat!: backup flag validation #240

merged 4 commits into from
May 28, 2024

Conversation

zahraKeshtkar
Copy link
Contributor

This pull request addresses an issue where the BackupEligible flag could be inadvertently altered during the login validation process. The following changes have been made:

  • Added a check in the validateLogin function to ensure that the BackupEligible flag remains consistent.
  • If the BackupEligible flag is found to be altered, an error is returned.
  • Updated the validateLogin function to handle this validation step appropriately.

@zahraKeshtkar zahraKeshtkar requested a review from a team as a code owner May 25, 2024 10:58
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 25, 2024 •
edited
Loading

Warning

Rate Limit Exceeded

@zahraKeshtkar has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 39 minutes and 21 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 0254b23 and 3b76dbf.

Walkthrough

The recent update introduces a critical validation step in the WebAuthn login process to ensure the integrity of the BackupEligible flag. This enhancement in webauthn/login.go strengthens the security of the login mechanism by verifying the flag's consistency before proceeding with other updates.

Changes

File Change Summary
webauthn/login.go Added a check for the BackupEligible flag to validate its stability before updating other flags based on response data.

A rabbit hops through lines of code,
Ensuring flags don't shift or erode.
With every hop, security grows,
As BackupEligible status shows.
In fields of data, safe and sound,
The login's trust is tightly bound.
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 25, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c99e7a7 and d7b3962.
Files selected for processing (1)
  • webauthn/login.go (1 hunks)

webauthn/login.go Outdated Show resolved Hide resolved
coderabbitai[bot]
coderabbitai bot reviewed May 25, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between d7b3962 and 0254b23.
Files selected for processing (1)
  • webauthn/login.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • webauthn/login.go

@james-d-elliott james-d-elliott added the spec/level/3 Webauthn Specification Level 3 Related label May 25, 2024
@james-d-elliott james-d-elliott changed the title Ensure BackupEligible flag consistency during login validation feat!: add backup flag validation May 25, 2024
@james-d-elliott james-d-elliott changed the title feat!: add backup flag validation feat!: backup flag validation May 25, 2024
james-d-elliott
james-d-elliott approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@james-d-elliott james-d-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james-d-elliott james-d-elliott merged commit 2195f33 into go-webauthn:master May 28, 2024
3 checks passed
fguillot added a commit to miniflux/v2 that referenced this pull request Oct 27, 2024
@fguillot
fix(webauthn): add backup eligibility flag workaround to avoid a 401
31fe245 
Since go-webauthn v0.11.0, the backup eligibility flag is strictly validated, but Miniflux does not store this flag.

This workaround to set the flag based on the parsed response, and avoid "BackupEligible flag inconsistency detected during login validation" error.

See go-webauthn/webauthn#240
fguillot added a commit to miniflux/v2 that referenced this pull request Oct 27, 2024
@fguillot
fix(webauthn): add backup eligibility flag workaround to avoid a 401
e3b1714 
Since go-webauthn v0.11.0, the backup eligibility flag is strictly validated, but Miniflux does not store this flag.

This workaround to set the flag based on the parsed response, and avoid "BackupEligible flag inconsistency detected during login validation" error.

See go-webauthn/webauthn#240
@fguillot fguillot mentioned this pull request Oct 27, 2024
Merged
5 tasks
fguillot added a commit to miniflux/v2 that referenced this pull request Oct 27, 2024
@fguillot
fix(webauthn): add backup eligibility flag workaround to avoid a 401
2bcc4b8 
Since go-webauthn v0.11.0, the backup eligibility flag is strictly validated, but Miniflux does not store this flag.

This workaround to set the flag based on the parsed response, and avoid "BackupEligible flag inconsistency detected during login validation" error.

See go-webauthn/webauthn#240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@james-d-elliott james-d-elliott james-d-elliott approved these changes

Assignees
No one assigned
Labels
spec/level/3 Webauthn Specification Level 3 Related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zahraKeshtkar @james-d-elliott