Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement alternative security #134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement alternative security #134

wants to merge 1 commit into from

Conversation

dustinb
Copy link

@dustinb dustinb commented Oct 23, 2022

Found that encrypting the body before the headers and size are calculated makes implementing an alternate security much easier.

sbinet
sbinet requested changes Nov 6, 2022
View reviewed changes
Copy link
Contributor

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies for the belated reply.

is the "NOTBAD" security protocol described in the official ZMQ document ?
we try to follow that document to retain compatibility with the official ZMQ implementation(s)

@dustinb
Copy link
Author

dustinb commented Nov 9, 2022

I was looking at implementing a curve type security mechanism. Not bad is a made up security. I struggled with this because the frame size is calculated before Encrypt is called.

I should clean this PR up and possibly implement curve and see if I run into the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbinet sbinet sbinet requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dustinb @sbinet