meta openapi:example work at APIExpr level too #3330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in my issue #3316 this meta doesn't work as the documentation says.
I've looked into the code for a while and really couldn't find a better way than this. The problem is that examples are generated on the Attribute expression, and the meta will work only there. My solution checks for the API meta during the generation of the openapi schema and sets the random generator seed to nil, and then adding the check to the
Example
method that created the example.I found the codebase kinda confusing and I won't be surprised if there's a better, cleaner way, but since nobody was looking into it I tried myself.