Websockets #1
Closed
Websockets #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 24, 2024 11:11
* in order to allow sending websocket messages also when a REST request is performed we have to change the code from annotation based to using the respective message template directly * introduce a test utility class to provide a nice API for the tests and encapsulate the client and session in a common place.
* this is very helpful in case you are not interested in the event producer but rather in the websocket part of the application * only use this implementation if none of the other producers are created i.e. neither the kafka nor the nats profile is active
* implement a AuthorizationManager that checks if the tenant of the topic matches the tenant stored in the TenantContext. Use this authorization manager to check any subscription request. * all other permissions are set such that the POC works. More thoughts are required before this code can be used in an production like environment. * we still need to check, if CSRF is required in our usecase. If so we need to adjust the code here to showcase how this can be achieved. Currently, it is disabled for websockets as well as Http requests.
…lients beyond instance borders.
TheManWhoStaresAtCode
force-pushed
the
websockets
branch
from
71551bd
to
118fe5b
Compare
* Finish cleanup of RestController: ** cleanup imports ** remove unused parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add some integration tests and test helpers for the websocket functionality.
also include a new producer that does not require an external service (kafka or nats) to be up and running