pi: correctly clear highlighted categories when clearing the search bar

goatcorp · Jun 19, 2024 · 7939223 · 7939223
1 parent a802529
commit 7939223
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/Dalamud/Interface/Internal/PluginCategoryManager.cs b/Dalamud/Interface/Internal/PluginCategoryManager.cs
@@ -373,6 +373,8 @@ public void ResetContentDirty()
     /// <param name="plugins">List of plugins whose categories should be highlighted.</param>
     public void SetCategoryHighlightsForPlugins(IEnumerable<PluginManifest> plugins)
     {
+        ArgumentNullException.ThrowIfNull(plugins);
+
         this.highlightedCategoryKinds.Clear();
 
         foreach (var entry in plugins)

diff --git a/Dalamud/Interface/Internal/Windows/PluginInstaller/PluginInstallerWindow.cs b/Dalamud/Interface/Internal/Windows/PluginInstaller/PluginInstallerWindow.cs
@@ -3573,7 +3573,7 @@ private void UpdateCategoriesOnSearchChange(string? previousSearchText)
     {
         if (string.IsNullOrEmpty(this.searchText))
         {
-            this.categoryManager.SetCategoryHighlightsForPlugins(null);
+            this.categoryManager.SetCategoryHighlightsForPlugins(Array.Empty<RemotePluginManifest>());
 
             // Reset here for good measure, as we're returning from a search
             this.openPluginCollapsibles.Clear();