Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Plugin Endorsements #1403

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kouzukii
Copy link

@Kouzukii Kouzukii commented Sep 18, 2023

As suggested on Discord, I'd like to add a simple endorsements system to Dalamud to positively reinforce plugin development and enable users to leave positive feedback without having to write a message through the "Leave Feedback" system.

I have personal experience with endorsements on nexusmods and steam workshop and I'd love to see this feature in dalamud as well.

Included in this PR:

  • Display endorsement count from PluginMaster in plugin list
  • New sort filter to sort available plugins by endorsement count
  • New button for installed plugins to endorse them
  • Save endorsed plugins in dalamudConfig.json

Relevant pull requests:

@KazWolfe
Copy link
Member

It is highly unlikely we will get this in prior to v9. Depending on our timeline, this means you may need to materially rework this PR to rebase it.

@Kouzukii
Copy link
Author

Kouzukii commented Sep 18, 2023

It is highly unlikely we will get this in prior to v9. Depending on our timeline, this means you may need to materially rework this PR to rebase it.

The overall changes are fairly minimal, I'll have a look into changing the target branch to v9

None of the changes in this PR are impacted by v9

@KazWolfe KazWolfe added the enhancement New feature or request label Jun 3, 2024
@KazWolfe
Copy link
Member

KazWolfe commented Jun 3, 2024

Is this still something we want to add to Dalamud?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants