feat: Encourage developers to use DLLs for devPlugins #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Text above the plugin needs to be updated. Still says can be either directory or dll path. |
I'm blind |
|
Sorry meant button, not plugin. But you got it. 👍 |
KazWolfe
changed the title
KazWolfe
requested changes
Sep 13, 2024
Comment on lines
-789
to
-793
| if (Directory.Exists(setting.Path)) | ||
| { | ||
| devDllFiles.AddRange(new DirectoryInfo(setting.Path).GetFiles("*.dll", SearchOption.AllDirectories)); | ||
| } | ||
| else if (File.Exists(setting.Path)) |
There was a problem hiding this comment.
For now, let's keep the recursive loading mode but just block setting folders in UI.
Removing this behavior should be an api11 todo so we have time to announce it.
| ImGuiHelpers.SafeTextColoredWrapped(ImGuiColors.DalamudGrey, Loc.Localize("DalamudSettingsDevPluginLocationsHint", "Add dev plugin load locations.\nThese can be either the directory or DLL path.")); | ||
| ImGuiHelpers.SafeTextColoredWrapped(ImGuiColors.DalamudGrey, Loc.Localize("DalamudSettingsDevPluginLocationsHint", "Add dev plugin load locations.\nThis must be a path to the plugin DLL.")); | ||
|
|
||
| var locationSelect = Loc.Localize("DalamudDevPluginLocationSelect", "Select Dev Plugin Location"); |
There was a problem hiding this comment.
Please change this label to Select DLL or similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed here.
Adds a button to pick a .dll for the dev plugin path, as well as removes the directory scan logic. While directory search hasn't been encouraged for a while now, there may still be people who use it, so this probably is gonna break someone's workflow.