Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NotificationMaster and Mini #3777

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Limiana
Copy link
Contributor

@Limiana Limiana commented Jul 3, 2024

Previous PR got removed because I renamed branch

@bleatbot bleatbot enabled auto-merge (squash) July 3, 2024 14:50
@bleatbot
Copy link
Collaborator

bleatbot commented Jul 3, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 5 hours.

Name Commit Status
NotificationMaster [stable] 504b6a6 Build failed (Diff)
Mini [stable] a7030b6 Build failed (Diff)
Show log - Review

@bleatbot bleatbot added the build failed This plugin failed to build. label Jul 3, 2024
@Aireil
Copy link
Member

Aireil commented Jul 9, 2024

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Jul 9, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
NotificationMaster [stable] 504b6a6 Build failed (Diff)
Mini [stable] a7030b6 Build failed (Diff)
Show log - Review

@Limiana
Copy link
Contributor Author

Limiana commented Jul 9, 2024

Needs either windows desktop packages to be updated in plogon or primary .net package to be pinned to the version Dalamud ships with it (later is better approach I think since you'd be building plugins against version that is actually in use), right now bot uses latest minor version of .Net
#3643 (comment)

@reiichi001 reiichi001 added the blocked-build Blocked due to build system issue that needs to be resolved. label Jul 12, 2024
@reiichi001
Copy link
Contributor

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Jul 25, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
Mini [stable] a7030b6 Build failed (Diff)
NotificationMaster [stable] 504b6a6 Build failed (Diff)
Show log - Review

@Limiana
Copy link
Contributor Author

Limiana commented Oct 10, 2024

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
Mini [stable] a7030b6 Build failed (Diff)
NotificationMaster [stable] 504b6a6 Build failed (Diff)
16 Needs (⚠️ 4 UNREVIEWED)
Type Name Version Reviewed by
Submodule https://github.com/NightmareXIV/ECommons 11fd2f06e1374e846e1aada06071da5fc7ef697a ⚠️ NEW
Submodule https://github.com/NightmareXIV/ECommons.git 11fd2f06e1374e846e1aada06071da5fc7ef697a ⚠️ NEW
Submodule https://github.com/NightmareXIV/NotificationMasterAPI 05b1ba788d5cb940ed8e82599eb88778c9cecdb0 ⚠️ NEW
NuGet NAudio.WinForms 2.2.1 ⚠️ NEW
NuGet NAudio 2.2.1 reiichi001
NuGet Microsoft.NETCore.Platforms 3.1.0 reiichi001
NuGet Microsoft.Win32.Registry 4.7.0 reiichi001
NuGet NAudio.Asio 2.2.1 reiichi001
NuGet NAudio.Core 2.2.1 reiichi001
NuGet NAudio.Midi 2.2.1 reiichi001
NuGet NAudio.Wasapi 2.2.1 reiichi001
NuGet NAudio.WinMM 2.2.1 reiichi001
NuGet System.Security.AccessControl 4.7.0 reiichi001
NuGet System.Security.Principal.Windows 4.7.0 reiichi001
2 hidden needs (known safe NuGet packages).
Show log - Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-build Blocked due to build system issue that needs to be resolved. build failed This plugin failed to build.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants