NoTankYou v7.1.0.2 #4730
Merged
NoTankYou v7.1.0.2 #4730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All builds OK! Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it! The average merge time for plugin updates is currently 6 hours.
14 Needs (
|
| Type | Name | Version | Reviewed by |
|---|---|---|---|
| Submodule | https://github.com/MidoriKami/KamiLib | 5ad86f9c8a6373f6b41dea915f0adce10373d05f | |
| Submodule | https://github.com/MidoriKami/KamiToolKit.git | 69f0b57e275c7a58e031569ddf502ec62e785ed2 | |
| NuGet | NetStone | 1.1.1 | reiichi001 |
| NuGet | HtmlAgilityPack | 1.11.46 | reiichi001 |
| NuGet | Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork | 0.0.2 | reiichi001 |
| NuGet | Microsoft.Build.Tasks.Git | 1.1.1 | goaaats |
8 hidden needs (known safe NuGet packages).
Show log - Review
|
Not sure why it's saying that KamiLib 5ad86f9c8a6373f6b41dea915f0adce10373d05f is new, when it is shown as reviewed already in a different PR #4695 (comment) KamiToolKit however probably does need a review, as this is the first of my plugins with KamiToolKit that's been updated since the new review system was implemented. Worth noting, this specific update didn't touch KamiToolKit, so it's unchanged since last review. |
philpax
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Monk Warnings appearing when too low level