Skip to content

Commit

Permalink
Fix comment in history thread ID is_must_parent
Browse files Browse the repository at this point in the history
  • Loading branch information
sim642 committed Aug 15, 2024
1 parent 8e54444 commit aa3fb6d
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/cdomain/value/cdomains/threadIdDomain.ml
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ struct
false
else if is_unique t' && P.equal p p' then (* t is already unique, so no need to compare sets *)
false (* thread is not its own parent *)
else ( (* both are unique, but different *)
else ( (* t is already unique, so no need to check sets *)
match GobList.remove_common_prefix Base.equal (List.rev p) (List.rev p') with (* prefixes are stored reversed *)
| [], _ -> true (* p is prefix of p' *)
| _ :: _, _ -> false
Expand All @@ -169,6 +169,9 @@ struct
false (* composing cannot fix incompatibility there *)
)

(* let may_create ((p, s) as t) ((p', s') as t') =
S.subset (S.union (S.of_list p) s) (S.union (S.of_list p') s') *)

let compose ((p, s) as current) ni =
if BatList.mem_cmp Base.compare ni p then (
let shared, unique = BatList.span (not % Base.equal ni) p in
Expand Down

0 comments on commit aa3fb6d

Please sign in to comment.