Handle operations on the addresses of non-array types #1480
+83
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3952a04.
…not only their types)
…struct ptr with an offset
karoliineh
commented
May 24, 2024
|
I was satisfied with the fix that I proposed here, but I think @sim642 was unsure if it was the right fix for this. @michael-schwarz, could you please take a look at it? Do you think this fix is reasonable? |
| begin match IdxDom.(to_bool (eq f_offset (neg (iDtoIdx n)))) with | ||
| | Some true -> `NoOffset | ||
| | _ when isArrayType f.ftype -> `Field (f, `Index (n, `NoOffset)) | ||
| | _ when GobOption.exists (Z.equal Z.zero) (ID.to_int n) -> `NoOffset (* adding (or subtracting) 0 to any type of pointer is ok *) |
There was a problem hiding this comment.
As it stands this means that the case of n being -f_offset is handled the same as the case where n is 0?
That seems odd.
Would this not have to be Field(f,NoOffset) here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1421