Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relational MM: Cluster LMust #1555

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

michael-schwarz
Copy link
Member

Currently, LMust is unclustered even when clusters are employed. This leads to precision loss compared to the unclustered variant when:

  • Values are published to a mutex a for some clusters only
  • a is added to LMust
  • Upon lock(a), V.mutex_inits is not consulted for any cluster, as a is in LMust

However, V.mutex_inits should still be consulted for clusters that have not been published yet.

This also clusters LMust and adds a regression test for this behavior.

References #1551

@michael-schwarz michael-schwarz added bug precision relational Relational analyses (Apron, affeq, lin2var) labels Aug 6, 2024
@michael-schwarz michael-schwarz merged commit 0d7ce37 into michael-schwarz-dissertation Aug 6, 2024
18 of 19 checks passed
@michael-schwarz michael-schwarz deleted the lmust-cluster branch August 6, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug precision relational Relational analyses (Apron, affeq, lin2var)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant