Add feature to allow reruns with different parameters in GobView #21
Conversation
sxprz
changed the title
sxprz
force-pushed
the
sxprz-fork/rerun-with-different-params
branch
from
28977ad
to
7546339
Compare
There was a problem hiding this comment.
Thank you for the PR and implementation of the analysis rerun option in GobView! Somehow the PR contains a set of commits for the inclusion of the goblint-http server that I think were already merged into master with #22. Could you try to rebase your branch? I think that would clean up the Thank you for the PR and implementation of the analysis rerun option in GobView! Somehow the PR contains a set of commits for the inclusion of the goblint-http server that I think were already merged into master with #22. Could you try to rebase your branch? I think that would help to see what changes were actually done in this PR and make the reviewing a little easier.
| [@react.component] | ||
| let make = () => { | ||
| <svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="currentColor" className="bi bi-arrow-down" viewBox="0 0 16 16"> | ||
| <path fillRule="evenodd" d="M8 1a.5.5 0 0 1 .5.5v11.793l3.146-3.147a.5.5 0 0 1 .708.708l-4 4a.5.5 0 0 1-.708 0l-4-4a.5.5 0 0 1 .708-.708L7.5 13.293V1.5A.5.5 0 0 1 8 1z"/> | ||
| </svg> | ||
| } |
There was a problem hiding this comment.
Is there some library where one could import the Icons from instead of defining an svg component?
There was a problem hiding this comment.
This icon is from Bootstrap Icons. The idea was to not import the whole JS library and use only a couple of icons that were necessary, but the library can be found here.
| let parameters_regex = Str.regexp({|\(--\(enable\|disable\) [-a-zA-Z0-9\._]+\)\|\(--set [-a-zA-Z0-9\._]+\(\[\(\+\|\-\)\]\)? \([-a-zA-Z0-9\._\/]+\|\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\|\[\(\(\(\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\|[-a-zA-Z0-9\._\/]+\)\(\([ ]*,[ ]*\)\(\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\|[-a-zA-Z0-9\._\/]+\)\)*\)\|\(\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\)\|[-a-zA-Z0-9\._\/]*\)\]\)\)\|\(--[-a-zA-Z0-9\._]+\(\[\(\+\|\-\)\]\)? \([-a-zA-Z0-9\._\/]+\|\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\|\[\(\(\(\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\|[-a-zA-Z0-9\._\/]+\)\(\([ ]*,[ ]*\)\(\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\|[-a-zA-Z0-9\._\/]+\)\)*\)\|\(\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\)\|[-a-zA-Z0-9\._\/]*\)\]\)\)|}); | ||
| let enable_disable_regex = Str.regexp({|--\(enable\|disable\) \([-a-zA-Z0-9\._]+\)|}); | ||
| let set_regex = Str.regexp({|--set \([-a-zA-Z0-9\._]+\(\[\(\+\|\-\)\]\)?\) \([-a-zA-Z0-9\._\/]+\|\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\|\[\(\(\(\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\|[-a-zA-Z0-9\._\/]+\)\(\([ ]*,[ ]*\)\(\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\|[-a-zA-Z0-9\._\/]+\)\)*\)\|\(\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\)\|[-a-zA-Z0-9\._\/]*\)\]\)|}); | ||
| let other_regex = Str.regexp({|--\([-a-zA-Z0-9\._]+\(\[\(\+\|\-\)\]\)?\) \([-a-zA-Z0-9\._\/]+\|\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\|\[\(\(\(\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\|[-a-zA-Z0-9\._\/]+\)\(\([ ]*,[ ]*\)\(\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\|[-a-zA-Z0-9\._\/]+\)\)*\)\|\(\("\|'\)[-a-zA-Z0-9\._, \!\?\$\*\/]*\("\|'\)\)\|[-a-zA-Z0-9\._\/]*\)\]\)|}); | ||
| let string_with_upticks_regex = Str.regexp({|'\(.*\)'|}); |
There was a problem hiding this comment.
This regex is quite hard to process. I think it would be nice to reuse the checking of command line arguments that is implemented for Goblint already. @sim642 Or do you think that is not possible?
There was a problem hiding this comment.
Indeed, these regexes are something we should avoid. I haven't looked at this PR in more detail: why does Gobview need to parse Goblint command lines at all, instead of just letting Goblint do it as usual?
sxprz
force-pushed
the
sxprz-fork/rerun-with-different-params
branch
from
4588ee6
to
8a1bc4a
Compare
|
Branch is now rebased onto gobview:master and does not contain duplicate commits from goblint-http-server any longer, @stilscher 👍🏻 |
This pull request introduces a feature that allows GobView users to rerun an analysis with different config options as part of my Bachelor Thesis. These have to be entered in an input bar. This input bar provides validation on whether the input is syntactically correct or whether the user is using not whitelisted options (in this case: parameters that are not compatible with the incremental analysis).
Parameters are following this format:
--set <option> <value>--<option> <value>--[enable/disable] <option>(syntactical sugar for boolean options)Options in the whitelist are:
incremental.force-reanalyze.funsincremental.reluctant.enabledincremental.compareincremental.detect-renamesincremental.restartincremental.postsolverannotation.goblint_precisionThe arrow in the parameter history allows for sorting its entries in regards to the analysis clock time.
Parameters in the history are clickable. When clicked, they will be added into the input bar.
Hovering over the status icon when it depicts a warning sign, shows an error message for the respective error that happened in the rerun.