-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alert for unsupported queries #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 20, 2023
michael-schwarz
approved these changes
Feb 2, 2024
This seems to cause a build error now:
I guess it also requires some change in Goblint or CIL itself? |
8 tasks
Yes, this is the corresponding not yet merged PR for the changes on the Goblint side: goblint/analyzer#1092 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the handling of the exception that is introduced in goblint/cil#147 (comment). It is used to distinguish between "No results found" and "Query not supported" in the syntactic analysis. In the case the Query is not supported, GobView will, with the changes of this PR display two different alert texts instead of just "No results found" in both cases. This should help to make the results of the search more transparent/understandable.
An example for a syntactic query that is not supported is finding the declaration of a function by name:
{"kind":["fun"],"target":["name","pthread_once"],"find":["decl"],"expression":"","mode":["Must"]}
on
tests/regression/00-sanity/01-assert.c