Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to OCaml 5.0 #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrade to OCaml 5.0 #26

wants to merge 3 commits into from

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Aug 16, 2023

I haven't checked whether Gobview actually works on OCaml 5.0 with these changes though.

On a side note, we really need to do #9 because jsoo-react 0.1 is now on opam, so we could avoid the pin and having to hack version bounds of some old jsoo-react fork ourselves.

@sim642 sim642 added bug Something isn't working enhancement New feature or request labels Aug 16, 2023
@sim642 sim642 marked this pull request as ready for review August 16, 2023 09:06
@sim642 sim642 requested a review from stilscher August 16, 2023 09:06
@sim642
Copy link
Member Author

sim642 commented Sep 11, 2023

The Gobview CI failure in goblint/analyzer#1137 seems to suggest that it doesn't actually work for some reason.

@michael-schwarz michael-schwarz removed the request for review from stilscher September 11, 2023 18:07
@sim642
Copy link
Member Author

sim642 commented Sep 12, 2023

I cherry-picked parts of this to master to fix the OCaml 5 compatibility, but not make it default yet.

Also the jsoo aliases didn't seem to work although jsoo's own unix.js uses them. Not sure what that's about, so I just duplicated the few functions for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants