Skip to content

Commit

Permalink
Merge branch 'main' into snyk-upgrade-cb8afc701e0b8106af02921a64c3ea40
Browse files Browse the repository at this point in the history
  • Loading branch information
connorjburton authored Aug 13, 2023
2 parents 5bd23ba + b5b55df commit 7b840e7
Show file tree
Hide file tree
Showing 4 changed files with 149 additions and 159 deletions.
15 changes: 3 additions & 12 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,10 @@ No matter how you want to get involved, we ask that you first learn what’s
expected of anyone who participates in the project by reading the Contribution
Guidelines and our [Code of Conduct][coc].

**Please Note:** GitHub is for bug reports and contributions primarily -
if you have a support question head over to [GoDaddy's Open Source
Software Slack channel][slack]. You can request an invite
[here][invite].

## Answering Questions

One of the most important and immediate ways you can support this project is
to answer questions on [Slack][slack] or [Github][issues]. Whether you’re
to answer questions on [Github][issues]. Whether you’re
helping a newcomer understand a feature or troubleshooting an edge case with a
seasoned developer, your knowledge and experience with a programming language
can go a long way to help others.
Expand Down Expand Up @@ -63,7 +58,7 @@ From a practical perspective, contributions are as simple as:
If you are interested in making a large change and feel unsure about its overall
effect, start with opening an Issue in the project's [Issue Tracker][issues]
with a high-level proposal and discuss it with the core contributors through
Github comments or in [Slack][slack]. After reaching a consensus with core
Github comments. After reaching a consensus with core
contributors about the change, discuss the best way to go about implementing it.

> Tip: Keep your master branch pointing at the original repository and make
Expand Down Expand Up @@ -97,9 +92,7 @@ patches:
willing to do the same for you.
- Split your change into multiple smaller changes. The smaller your change,
the higher the probability that somebody will take a quick look at it.
- Mention the change on [Slack][slack]. If it is urgent, provide reasons why it
is important to get this change landed. Remember that you are asking for valuable
time from other professional developers.
- Remember that you are asking for valuable time from other professional developers.

**Note that anyone is welcome to review and give feedback on a change, but only
people with commit access to the repository can approve it.**
Expand All @@ -123,6 +116,4 @@ guide with respect to patterns, naming, documentation and testing.

[issues]: LINK_TO_PROJECTS_ISSUES_ON_GITHUB
[coc]: ./CODE_OF_CONDUCT.md
[slack]: https://godaddy-oss.slack.com/
[fork]: https://help.github.com/en/articles/fork-a-repo
[invite]: https://godaddy-oss-slack.herokuapp.com
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:20.2-alpine
FROM node:20.5.1-alpine
WORKDIR /usr/src/vault-cert-finder
COPY . ./
RUN yarn
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"dependencies": {
"debug": "4.3.4",
"dotenv": "16.1.3",
"node-vault": "0.9.22"
"node-vault": "0.10.2"
},
"devDependencies": {
"@commitlint/cli": "17.6.3",
Expand Down
Loading

0 comments on commit 7b840e7

Please sign in to comment.